Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): add disclaimer for boostrapping feature flags behavior post-init #9988

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

havenbarnes
Copy link
Contributor

@havenbarnes havenbarnes commented Nov 26, 2024

Changes

I received a ticket this week where a user was expecting feature flag bootstrapping to override flag values even after initialization. While looking into their question I came across a few other tickets around the same confusion from the last few months. Adding a couple of blurbs to the bootstrapping documentation to clear up this behavior and suggest proper overrides if that is what is desired.

Please describe.

Add screenshots or screen recordings for visual / UI-focused changes.

Screenshot 2024-11-26 at 3 19 27 PM Screenshot 2024-11-26 at 3 19 38 PM

Checklist

  • Words are spelled using American English
  • Titles are in sentence case
  • Feature names are in sentence case too
  • Use relative URLs for internal links
  • If I moved a page, I added a redirect in vercel.json
  • Remove this template if you're not going to fill it out!

Useful resources

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog ✅ Ready (Inspect) Visit Preview Nov 27, 2024 10:04pm

Copy link
Contributor

@ivanagas ivanagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some minor style comments :)

contents/docs/feature-flags/bootstrapping.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@dmarticus dmarticus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamped from a "this is how flags work" standpoint

@havenbarnes havenbarnes merged commit 756c53a into master Dec 2, 2024
3 checks passed
@havenbarnes havenbarnes deleted the chore/update-boostrapping-doc branch December 2, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants